Skip to content

[DNM] Rebranch testing #81190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: rebranch
Choose a base branch
from
Draft

[DNM] Rebranch testing #81190

wants to merge 1 commit into from

Conversation

AnthonyLatsis
Copy link
Collaborator

No description provided.

@AnthonyLatsis AnthonyLatsis requested a review from bnbarham April 30, 2025 06:54
bnbarham
bnbarham reviewed Apr 30, 2025
View reviewed changes
@AnthonyLatsis

This comment was marked as duplicate.

Sign in to view
aschwaighofer
aschwaighofer approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you

@bnbarham
Copy link
Contributor

bnbarham commented May 2, 2025

@aschwaighofer do we actually care about checking for captures(none) and nuw? I mostly ask because it would be nice if we could avoid main conflicts here, which we could do if we used {{.*}} rather than the actual checks.

@AnthonyLatsis AnthonyLatsis mentioned this pull request May 4, 2025
Merged
@AnthonyLatsis AnthonyLatsis changed the title [rebranch] Adjust some tests to pass again [DNM] [rebranch] Adjust some tests to pass again May 4, 2025
adrian-prantl
adrian-prantl reviewed May 5, 2025
View reviewed changes
test/DebugInfo/shadowcopy-linetable.swift Outdated
@@ -24,7 +24,7 @@ func foo(_ x: inout Int64) {
// IRCHECK-NEXT: call void @llvm.memset.{{.*}}(ptr align {{(4|8)}} %[[X]], i8 0
// IRCHECK: store ptr %0, ptr %[[X]], align {{(4|8)}}
// IRCHECK-SAME: !dbg ![[LOC0:.*]]
// IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds %Ts5Int64V, ptr %0, i32 0, i32 0,
// IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds nuw %Ts5Int64V, ptr %0, i32 0, i32 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnthonyLatsis AnthonyLatsis force-pushed the rebranch-fix-tests branch 2 times, most recently from f36c739 to 5e79ea5 Compare May 8, 2025 08:14
@AnthonyLatsis AnthonyLatsis mentioned this pull request May 8, 2025
Merged
@AnthonyLatsis AnthonyLatsis changed the title [DNM] [rebranch] Adjust some tests to pass again [DNM] [rebranch] Adjust some tests to pass again (part 2) May 8, 2025
@AnthonyLatsis AnthonyLatsis force-pushed the rebranch-fix-tests branch 3 times, most recently from a008ec9 to 20d38f9 Compare May 9, 2025 14:34
@AnthonyLatsis AnthonyLatsis marked this pull request as draft May 20, 2025 17:57
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please build toolchain Ubuntu 24.04

@AnthonyLatsis AnthonyLatsis changed the title [DNM] [rebranch] Adjust some tests to pass again (part 2) [DNM] Rebranch testing Jun 27, 2025
@Xazax-hun
Copy link
Contributor

swiftlang/llvm-project#10909

@swift-ci please smoke test macOS

@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#11120

@swift-ci please test Windows

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test Windows

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Aug 5, 2025 •
edited
Loading

@compnerd Any ideas on how to address this?

swiftAPIDigester.lib(ModuleAnalyzerNodes.cpp.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static bool __cdecl clang::SwiftPrivateAttr::classof(class clang::Attr const *)" (__imp_?classof@SwiftPrivateAttr@clang@@SA_NPEBVAttr@2@@Z) referenced in function "public: bool __cdecl swift::ide::api::SDKContext::shouldIgnore(class swift::Decl *,class swift::Decl const *)const " (?shouldIgnore@SDKContext@api@ide@swift@@QEBA_NPEAVDecl@4@PEBV54@@Z)

class CLANG_ABI SwiftPrivateAttr : public InheritableAttr {
public:
  // Factory methods
  static SwiftPrivateAttr *CreateImplicit(ASTContext &Ctx, const AttributeCommonInfo &CommonInfo);
  static SwiftPrivateAttr *Create(ASTContext &Ctx, const AttributeCommonInfo &CommonInfo);
  static SwiftPrivateAttr *CreateImplicit(ASTContext &Ctx, SourceRange Range = {});
  static SwiftPrivateAttr *Create(ASTContext &Ctx, SourceRange Range = {});

  // Constructors
  SwiftPrivateAttr(ASTContext &Ctx, const AttributeCommonInfo &CommonInfo
             );

  SwiftPrivateAttr *clone(ASTContext &C) const;
  void printPretty(raw_ostream &OS,
                   const PrintingPolicy &Policy) const;
  const char *getSpelling() const;


  static bool classof(const Attr *A) { return A->getKind() == attr::SwiftPrivate; }
};

https://ci-external.swift.org/view/Pull%20Request/job/swift-PR-windows/43993

I tried a different attribute here, and this is not specific to SwiftPrivateAttr.

@compnerd
Copy link
Member

compnerd commented Aug 5, 2025

The __declspec(dllimport) seems to be the key piece to focus on. I don't think that we are yet linking dynamically against the Swift compiler. I think that you likely have an issue with macros making it think that you are importing a symbol from a DLL rather than statically linking. I would investigate the output of -E -dD and see why it it expanding to __declspec(dllimport) rather than /**/.

@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#11127

@swift-ci please test Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham left review comments

@adrian-prantl adrian-prantl adrian-prantl left review comments

@aschwaighofer aschwaighofer aschwaighofer approved these changes

@eeckstein eeckstein Awaiting requested review from eeckstein

@zoecarver zoecarver Awaiting requested review from zoecarver

@egorzhdan egorzhdan Awaiting requested review from egorzhdan

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun

@j-hui j-hui Awaiting requested review from j-hui

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar

@susmonteiro susmonteiro Awaiting requested review from susmonteiro

@hnrklssn hnrklssn Awaiting requested review from hnrklssn

@rjmccall rjmccall Awaiting requested review from rjmccall

@ktoso ktoso Awaiting requested review from ktoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AnthonyLatsis @bnbarham @Xazax-hun @compnerd @adrian-prantl @aschwaighofer